netdev - Re: [PATCH] atm/svc: Fix blocking in wait loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140812.150225.33325749199708788.davem@davemloft.net>
Date:	Tue, 12 Aug 2014 15:02:25 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	chas@....nrl.navy.mil
Cc:	peterz@...radead.org, fengguang.wu@...el.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org, lkp@...org,
	linux-atm-general@...ts.sourceforge.net
Subject: Re: [PATCH] atm/svc: Fix blocking in wait loop

From: chas williams - CONTRACTOR <chas@....nrl.navy.mil>
Date: Tue, 12 Aug 2014 08:12:26 -0400

> One should not call blocking primitives inside a wait loop, since both
> require task_struct::state to sleep, so the inner will destroy the
> outer state.
> 
> sigd_enq() will possibly sleep for alloc_skb().  Move sigd_enq() before
> prepare_to_wait() to avoid sleeping while waiting interruptibly.  You do
> not actually need to call sigd_enq() after the initial prepare_to_wait()
> because we test the termination condition before calling schedule().
> 
> Based on suggestions from Peter Zijlstra.
> 
> Signed-off-by: Chas Williams <chas@....n4rl.navy.mil>
> Acked-by: Peter Zijlstra <peterz@...radead.org>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html