netdev - Re: [PATCH net-next] tg3: fix return value in tg3_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140813.161734.2107510820154608070.davem@davemloft.net>
Date:	Wed, 13 Aug 2014 16:17:34 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	_govind@....com
Cc:	prashant@...adcom.com, mchan@...adcom.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] tg3: fix return value in tg3_get_stats64

From: Govindarajulu Varadarajan <_govind@....com>
Date: Wed, 13 Aug 2014 13:04:56 +0530

> When tp->hw_stats is 0, tg3_get_stats64 should display previously
> recorded stats. So it returns &tp->net_stats_prev. But the caller,
> dev_get_stats, ignores the return value.
> 
> Fix this by assigning tp->net_stats_prev to stats and returning stats.
> 
> Signed-off-by: Govindarajulu Varadarajan <_govind@....com>

Applied, but please target 'net' for bug fixes in the future.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html