netdev - Re: [PATCH net-next 02/10] IB/mlx5: Add support for extended query device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53EB5A0C.8040209@cogentembedded.com>
Date:	Wed, 13 Aug 2014 16:29:00 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Eli Cohen <eli@....mellanox.co.il>, roland@...nel.org,
	davem@...emloft.net
CC:	netdev@...r.kernel.org, rdma@...r.kernel.org, amirv@...lanox.com,
	yevgenyp@...lanox.com, Eli Cohen <eli@...lanox.com>
Subject: Re: [PATCH net-next 02/10] IB/mlx5: Add support for extended query
 device

Hello.

On 8/13/2014 3:39 PM, Eli Cohen wrote:

> Add a new entry for query device extended which currently has identical
> functionality to query_device and publish support for it.

> Signed-off-by: Eli Cohen <eli@...lanox.com>
> ---
>   drivers/infiniband/hw/mlx5/main.c | 25 +++++++++++++++++++++++--
>   1 file changed, 23 insertions(+), 2 deletions(-)

> diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c
> index d8907b20522a..63fddeec90af 100644
> --- a/drivers/infiniband/hw/mlx5/main.c
> +++ b/drivers/infiniband/hw/mlx5/main.c
[...]
> @@ -775,6 +781,17 @@ static int mlx5_ib_dealloc_pd(struct ib_pd *pd)
>   	return 0;
>   }
>
> +static int mlx5_ib_query_device_ex(struct ib_device *device,
> +				   struct ib_device_attr *attr,
> +				   struct ib_udata *uhw)
> +{
> +	int err;
> +
> +	err = query_device(device, attr);
> +
> +	return err;
> +}

   Why not just:

	return query_device(device, attr);

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html