netdev - Re: [PATCH v2 1/1] net: fec: ptp: avoid register access when ipg clock is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140814091259.GA11727@netboy>
Date:	Thu, 14 Aug 2014 11:12:59 +0200
From:	Richard Cochran <richardcochran@...il.com>
To:	"fugang.duan@...escale.com" <fugang.duan@...escale.com>
Cc:	"shawn.guo@...aro.org" <shawn.guo@...aro.org>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH v2 1/1] net: fec: ptp: avoid register access when ipg
 clock is disabled

On Thu, Aug 14, 2014 at 09:02:07AM +0000, fugang.duan@...escale.com wrote:
> 
> I know your means. Even if cancel the time_keep work, ptp timer still is running and continutious.
> The time_keep work just to avoid timer overrun because FEC just support 32bit counter.

Right, so the time_keep must continue when the clock is running. It
does not depend on whether time stamping is enabled.

> And, you said "return an error", I don't know your mean.
> In addition, when clock is disabled, FEC ptp counter don't run any more.

You can return an error from your 'gettime' method.

Thanks,
Richard
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html