netdev - Re: [PATCH] can: c_can: Fix return value check in c_can_plat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <53EC8B57.6070300@pengutronix.de>
Date:	Thu, 14 Aug 2014 12:11:35 +0200
From:	Marc Kleine-Budde <mkl@...gutronix.de>
To:	weiyj_lk@....com, Wolfgang Grandegger <wg@...ndegger.com>,
	Grant Likely <grant.likely@...aro.org>,
	Rob Herring <robh+dt@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Chen Gang <gang.chen@...anux.com>,
	George Cherian <george.cherian@...com>,
	Sachin Kamat <sachin.kamat@...aro.org>,
	"Lad, Prabhakar" <prabhakar.csengg@...il.com>,
	Pavel Machek <pavel@...x.de>, Thor Thayer <tthayer@...era.com>,
	Mugunthan V N <mugunthanvnm@...com>,
	Wolfram Sang <wsa@...g-engineering.com>
CC:	Wei Yongjun <yongjun_wei@...ndmicro.com.cn>,
	linux-can@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] can: c_can: Fix return value check in c_can_plat_probe()

On 08/14/2014 02:58 AM, weiyj_lk@....com wrote:
> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> 
> In case of error, the function devm_ioremap() returns NULL pointer
> not ERR_PTR(). The IS_ERR() test in the return value check should
> be replaced with NULL test.
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>

Dan Carpenter already provided this fix. It will be included in my next
pull request to David's net.

Thanks,
Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)