netdev - Re: [PATCH] sit: Fix ipip6_tunnel_lookup device matching criteria

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <53ECA6C4.9080305@cogentembedded.com>
Date:	Thu, 14 Aug 2014 16:08:36 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Shmulik Ladkani <shmulik.ladkani@...il.com>,
	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
CC:	Sascha Hlusiak <contact@...chahlusiak.de>
Subject: Re: [PATCH] sit: Fix ipip6_tunnel_lookup device matching criteria

Hello.

On 8/14/2014 1:32 PM, Shmulik Ladkani wrote:

> As of 4fddbf5d78, when looking up a tunnel, tunnel's underlying

    Please also specify that commit's summary line in parens.

> interface (t->parms.link) is verified to match incoming traffic's
> ingress device.

> However the comparison was incorrectly based on skb->dev->iflink.

> Instead, dev->ifindex should be used, which correctly represents the
> interface from which the IP stack hands the ipip6 packets.

> This allows setting up sit tunnels bound to vlan interfaces (otherwise
> incoming ipip6 traffic on the vlan interface was dropped due to
> ipip6_tunnel_lookup match failure).

> Signed-off-by: Shmulik Ladkani <shmulik.ladkani@...il.com>

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html