netdev - Re: [PATCH net] macvlan: Fix the bug when destroy macvlan dev port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1408037910.6804.22.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Thu, 14 Aug 2014 10:38:30 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Cong Wang <cwang@...pensource.com>
Cc:	Ding Tianhong <dingtianhong@...wei.com>,
	"Keller, Jacob E" <jacob.e.keller@...el.com>,
	"David S. Miller" <davem@...emloft.net>,
	Patrick McHardy <kaber@...sh.net>,
	Netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net] macvlan: Fix the bug when destroy macvlan dev port

On Thu, 2014-08-14 at 09:58 -0700, Cong Wang wrote:
> On Thu, Aug 14, 2014 at 2:12 AM, Ding Tianhong <dingtianhong@...wei.com> wrote:
> >
> > To fix this problem, we need to check whether the port is exist when calling
> > macvlan_port_destroy(), do nothing if the port has been destroyed yet.
> >
> 
> As I said, this will make the first call of macvlan_port_destroy()
> free the port,
> which was freed by the last one before.
> 
> Why not just revert your change? It doesn't give any benefit.
> --

Yes please, I think patch should be reverted.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html