netdev - Re: [PATCH net] macvlan: Fix the bug when destroy macvlan dev port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140814.143236.466435177296125156.davem@redhat.com>
Date:	Thu, 14 Aug 2014 14:32:36 -0700 (PDT)
From:	David Miller <davem@...hat.com>
To:	eric.dumazet@...il.com
Cc:	cwang@...pensource.com, dingtianhong@...wei.com,
	jacob.e.keller@...el.com, kaber@...sh.net, netdev@...r.kernel.org
Subject: Re: [PATCH net] macvlan: Fix the bug when destroy macvlan dev port

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 14 Aug 2014 10:38:30 -0700

> On Thu, 2014-08-14 at 09:58 -0700, Cong Wang wrote:
>> On Thu, Aug 14, 2014 at 2:12 AM, Ding Tianhong <dingtianhong@...wei.com> wrote:
>> >
>> > To fix this problem, we need to check whether the port is exist when calling
>> > macvlan_port_destroy(), do nothing if the port has been destroyed yet.
>> >
>> 
>> As I said, this will make the first call of macvlan_port_destroy()
>> free the port,
>> which was freed by the last one before.
>> 
>> Why not just revert your change? It doesn't give any benefit.
>> --
> 
> Yes please, I think patch should be reverted.

I agree, this should be reverted, I'm going to do it myself.

 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html