netdev - Re: [PATCH net-next] lec: Use rtnl lock/unlock when updating MTU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140814.143706.1833450188258591738.davem@redhat.com>
Date:	Thu, 14 Aug 2014 14:37:06 -0700 (PDT)
From:	David Miller <davem@...hat.com>
To:	chas@....nrl.navy.mil
Cc:	netdev@...r.kernel.org, linux-atm-general@...ts.sourceforge.net
Subject: Re: [PATCH net-next] lec: Use rtnl lock/unlock when updating MTU

From: Chas Williams - CONTRACTOR <chas@....nrl.navy.mil>
Date: Thu, 14 Aug 2014 09:19:47 -0400

> The LECS response contains the MTU that should be used.  Correctly
> synchronize with other layers when updating.
> 
> Signed-off-by: Chas Williams - CONTRACTOR <chas@....nrl.navy.mil>

I don't think you can sleep from this function, which rtnl_lock() may
require.  Look elsewhere in this routine, it's doing GFP_ATOMIC
allocations even.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html