netdev - Re: [PATCH v3] sit: Fix ipip6_tunnel_lookup device matching criteria

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140814.144010.2242230149048926758.davem@redhat.com>
Date:	Thu, 14 Aug 2014 14:40:10 -0700 (PDT)
From:	David Miller <davem@...hat.com>
To:	shmulik.ladkani@...il.com
Cc:	netdev@...r.kernel.org, sergei.shtylyov@...entembedded.com,
	contact@...chahlusiak.de, nicolas.dichtel@...nd.com
Subject: Re: [PATCH v3] sit: Fix ipip6_tunnel_lookup device matching
 criteria

From: Shmulik Ladkani <shmulik.ladkani@...il.com>
Date: Thu, 14 Aug 2014 15:27:20 +0300

> As of 4fddbf5d78 ("sit: strictly restrict incoming traffic to tunnel link device"),
> when looking up a tunnel, tunnel's underlying interface (t->parms.link)
> is verified to match incoming traffic's ingress device.
> 
> However the comparison was incorrectly based on skb->dev->iflink.
> 
> Instead, dev->ifindex should be used, which correctly represents the
> interface from which the IP stack hands the ipip6 packets.
> 
> This allows setting up sit tunnels bound to vlan interfaces (otherwise
> incoming ipip6 traffic on the vlan interface was dropped due to
> ipip6_tunnel_lookup match failure).
> 
> Signed-off-by: Shmulik Ladkani <shmulik.ladkani@...il.com>
> Acked-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html