netdev - Re: network interfaces called "all", "default" or "config"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACsCDONU9Zq902rj6aJXGZGnPfAWbxsiFe9mMS8usyyUdTYa9A@mail.gmail.com>
Date:	Fri, 15 Aug 2014 09:33:51 +0100
From:	Stephane Chazelas <stephane.chazelas@...il.com>
To:	Cong Wang <cwang@...pensource.com>
Cc:	Randy Dunlap <rdunlap@...radead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: network interfaces called "all", "default" or "config"

Yes, I know  those are also used for the eth0:1 "aliases", but the bug
is, since it is allowed to do

    ip link add link eth0 eth0:123 type vlan id 123

Then the

    ip link del link eth0 eth0:123

should be allowed as well. Or probably better to avoid confusion

    ip link add link eth0 foo:bar type vlan id 123

should not be allowed.

Worse:

   ip link add link eth0 foo:bar type vlan id 1
   ip link add link eth0 foo type vlan id 2

   ip link del foo:bar

deletes foo instead of foo:bar.



On 14 August 2014 19:37, Cong Wang <cwang@...pensource.com> wrote:
> On Thu, Aug 14, 2014 at 2:41 AM, Stephane Chazelas
> <stephane.chazelas@...il.com> wrote:
>> By the way, this is related:
>>
>> $ ip link add link eth0 eth0:123 type vlan id 123
>> $ ip link del link eth0 eth0:123
>> RTNETLINK answers: Operation not supported
>
> Kernel reads "eth0:123" as an alias of "eth0", so it will just
> truncate the dev name into "eth0":
>
>
>         ifr.ifr_name[IFNAMSIZ-1] = 0;
>
>         colon = strchr(ifr.ifr_name, ':');
>         if (colon)
>                 *colon = 0;
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html