netdev - Re: [PATCH] isdn/gigaset: use USB API functions rather than constants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53EF3857.1070000@imap.cc>
Date:	Sat, 16 Aug 2014 12:54:15 +0200
From:	Tilman Schmidt <tilman@...p.cc>
To:	Himangi Saraogi <himangi774@...il.com>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
CC:	Hansjoerg Lipp <hjlipp@....de>, Karsten Keil <isdn@...ux-pingi.de>,
	gigaset307x-common@...ts.sourceforge.net,
	Julia Lawall <julia.lawall@...6.fr>
Subject: Re: [PATCH] isdn/gigaset: use USB API functions rather than constants

Am 15.08.2014 um 18:24 schrieb Himangi Saraogi:
> This patch introduces the use of the function usb_endpoint_num.
> 
> The Coccinelle semantic patch that makes these changes is as follows:
> 
> @@ struct usb_endpoint_descriptor *epd; @@
> 
> - (epd->bEndpointAddress & \(USB_ENDPOINT_NUMBER_MASK\|0x0f\))
> + usb_endpoint_num(epd)
> 
> Signed-off-by: Himangi Saraogi <himangi774@...il.com>
> Acked-by: Julia Lawall <julia.lawall@...6.fr>
Acked-by: Tilman Schmidt <tilman@...p.cc>

Nice.
Are you planning a similar patch for bas-gigaset.c too?
Otherwise I'll prepare one myself.

Thanks,
Tilman


> ---
>  drivers/isdn/gigaset/usb-gigaset.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/isdn/gigaset/usb-gigaset.c b/drivers/isdn/gigaset/usb-gigaset.c
> index d0a41cb..00d4077 100644
> --- a/drivers/isdn/gigaset/usb-gigaset.c
> +++ b/drivers/isdn/gigaset/usb-gigaset.c
> @@ -751,7 +751,7 @@ static int gigaset_probe(struct usb_interface *interface,
>  	/* Fill the interrupt urb and send it to the core */
>  	usb_fill_int_urb(ucs->read_urb, udev,
>  			 usb_rcvintpipe(udev,
> -					endpoint->bEndpointAddress & 0x0f),
> +					usb_endpoint_num(endpoint)),
>  			 ucs->rcvbuf, buffer_size,
>  			 gigaset_read_int_callback,
>  			 cs, endpoint->bInterval);
> 

-- 
Tilman Schmidt                              E-Mail: tilman@...p.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html