netdev - Re: [PATCH] macvlan: Allow setting multicast filter on all macvlan types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140817094308.GD21143@redhat.com>
Date:	Sun, 17 Aug 2014 11:43:08 +0200
From:	"Michael S. Tsirkin" <mst@...hat.com>
To:	Vladislav Yasevich <vyasevic@...hat.com>
Cc:	netdev@...r.kernel.org,
	John Fastabend <john.r.fastabend@...el.com>,
	Jason Wang <jasowang@...hat.com>
Subject: Re: [PATCH] macvlan: Allow setting multicast filter on all macvlan
 types

On Fri, Aug 15, 2014 at 01:04:59PM -0400, Vladislav Yasevich wrote:
> Currently, macvlan code restricts multicast and unicast
> filter setting only to passthru devices.  As a result,
> if a guest using macvtap wants to receive multicast
> traffic, it has to set IFF_ALLMULTI or IFF_PROMISC.
> 
> This patch makes it possible to use the fdb interface
> to add multicast addresses to the filter thus allowing
> a guest to receive only targeted multicast traffic.
> 
> CC: John Fastabend <john.r.fastabend@...el.com>
> CC: Michael S. Tsirkin <mst@...hat.com>
> CC: Jason Wang <jasowang@...hat.com>
> Signed-off-by: Vladislav Yasevich <vyasevic@...hat.com>

Acked-by: Michael S. Tsirkin <mst@...hat.com>

> ---
>  drivers/net/macvlan.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c
> index ef8a5c2..fad4b9e 100644
> --- a/drivers/net/macvlan.c
> +++ b/drivers/net/macvlan.c
> @@ -739,7 +739,10 @@ static int macvlan_fdb_add(struct ndmsg *ndm, struct nlattr *tb[],
>  	struct macvlan_dev *vlan = netdev_priv(dev);
>  	int err = -EINVAL;
>  
> -	if (!vlan->port->passthru)
> +	/* Support unicast filter only on passthru devices.
> +	 * Multicast filter should be allowed on all devices.
> +	 */
> +	if (!vlan->port->passthru && is_unicast_ether_addr(addr))
>  		return -EOPNOTSUPP;
>  
>  	if (flags & NLM_F_REPLACE)
> @@ -760,7 +763,10 @@ static int macvlan_fdb_del(struct ndmsg *ndm, struct nlattr *tb[],
>  	struct macvlan_dev *vlan = netdev_priv(dev);
>  	int err = -EINVAL;
>  
> -	if (!vlan->port->passthru)
> +	/* Support unicast filter only on passthru devices.
> +	 * Multicast filter should be allowed on all devices.
> +	 */
> +	if (!vlan->port->passthru && is_unicast_ether_addr(addr))
>  		return -EOPNOTSUPP;
>  
>  	if (is_unicast_ether_addr(addr))
> -- 
> 1.9.3
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html