netdev - Re: [PATCH net] tipc: fix message importance range check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140817150003.586becdcec969d0f4625595e@qrator.net>
Date:	Sun, 17 Aug 2014 15:00:03 +0400
From:	Dmitry Popov <ixaphire@...tor.net>
To:	<erik.hugne@...csson.com>, "David S. Miller" <davem@...emloft.net>
Cc:	<jon.maloy@...csson.com>, <ying.xue@...driver.com>,
	<richard.alpe@...csson.com>, <netdev@...r.kernel.org>,
	<tipc-discussion@...ts.sourceforge.net>
Subject: Re: [PATCH net] tipc: fix message importance range check

On Fri, 15 Aug 2014 16:44:35 +0200
<erik.hugne@...csson.com> wrote:

> -static inline void tipc_port_set_importance(struct tipc_port *port, int imp)
> +static inline int tipc_port_set_importance(struct tipc_port *port, int imp)
>  {
> +	if (imp > TIPC_CRITICAL_IMPORTANCE)
> +		return -EINVAL
>  	msg_set_importance(&port->phdr, (u32)imp);
>  }

1) Semicolon is missing after return -EINVAL,
2) return 0 is missing at the end of this function.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html