netdev - Re: [PATCH] batman-adv: Fix parameter order of hlist_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140816.191951.1131268812372725722.davem@davemloft.net>
Date:	Sat, 16 Aug 2014 19:19:51 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	sven@...fation.org
Cc:	netdev@...r.kernel.org, akpm@...ux-foundation.org
Subject: Re: [PATCH] batman-adv: Fix parameter order of hlist_add_behind

From: Sven Eckelmann <sven@...fation.org>
Date: Fri, 15 Aug 2014 10:19:39 +0200

> 1d023284c31a4e40a94d5bbcb7dbb7a35ee0bcbc ("list: fix order of arguments for
> hlist_add_after(_rcu)") was incorrectly rebased on top of
> d9124268d84a836f14a6ead54ff9d8eee4c43be5 ("batman-adv: Fix out-of-order
> fragmentation support"). The parameter order change of the rebased patch was
> not re-applied as expected. This causes a memory leak and can cause crashes
> when out-of-order packets are received. hlist_add_behind will try to access the
> uninitalized list pointers of frag_entry_new to find the previous/next entry
> and may modify/read random memory locations.
> 
> Signed-off-by: Sven Eckelmann <sven@...fation.org>
> Cc: Andrew Morton <akpm@...ux-foundation.org>

Applied, thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html