lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Tue, 19 Aug 2014 11:01:48 -0700
From:	Joe Perches <joe@...ches.com>
To:	Krzysztof Majzerowicz-Jaszcz <cristos@...serv.org>
Cc:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
	Alexander Duyck <alexander.h.duyck@...el.com>,
	netdev <netdev@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] drivers: net: ethernet: intel: e1000:
 e1000_ethertoo.c coding style fixes

On Tue, 2014-08-19 at 19:33 +0200, Krzysztof Majzerowicz-Jaszcz wrote:
> On 19/08/14 18:04, Jeff Kirsher wrote:
> > On Mon, Aug 18, 2014 at 3:21 PM, Krzysztof Majzerowicz-Jaszcz
> > <cristos@...serv.org> wrote:
> >> Fixed many errors/warnings and checks in e1000_ethtool.c reported by checkpatch.pl
> >> Suggestions from Joe Perches and Alexander Duyck applied as well
> >>
> >> Signed-off-by: Krzysztof Majzerowicz-Jaszcz <cristos@...serv.org>
> >> ---
> >>  drivers/net/ethernet/intel/e1000/e1000_ethtool.c | 155 ++++++++++++-----------
> >>  1 file changed, 79 insertions(+), 76 deletions(-)
> >>
> > 
> > Thanks Krzysztof, I will add your patch to my queue and I can fix up
> > the patch title for you. :-)
> >
> 
> Thank you :). Sorry for that patch title - I guess that 'first pancake is always spoiled'.
> Nonetheless, that makes my first successful contribution to the kernel <yay> ;)

Yay for Krzysztof.

Now you could fix the same "*(foo + bar) == 0xXX" uses
in drivers/net/ethernet/intel/e1000e/ethtool.c

drivers/net/ethernet/intel/e1000e/ethtool.c:	if (*(skb->data + 3) == 0xFF)
drivers/net/ethernet/intel/e1000e/ethtool.c:		if ((*(skb->data + frame_size / 2 + 10) == 0xBE) &&
drivers/net/ethernet/intel/e1000e/ethtool.c:		    (*(skb->data + frame_size / 2 + 12) == 0xAF))

as well if you wanted to follow up on your first success.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists