lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 21 Aug 2014 10:25:09 +0100 From: Mark Einon <mark.einon@...il.com> To: Stephen Hemminger <stephen@...workplumber.org> Cc: gregkh@...uxfoundation.org, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH 8/8] staging: et131x: Implement NAPI support On Wed, Aug 20, 2014 at 08:25:45PM -0700, Stephen Hemminger wrote: > On Wed, 20 Aug 2014 23:17:58 +0100 > Mark Einon <mark.einon@...il.com> wrote: > > > - bool done = true; > > + int count = 0; > > + int limit = budget; > > + bool not_done = false; > > Don't use negative variables. Better to keep the original done variable. Fair comment, I'll send a v2. Cheers, Mark -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists