netdev - Re: [PATCH 1/1] netfilter/jump_label: use HAVE_JUMP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140821152435.GB16498@breakpoint.cc>
Date:	Thu, 21 Aug 2014 17:24:35 +0200
From:	Florian Westphal <fw@...len.de>
To:	Zhouyi Zhou <yizhouzhou@....ac.cn>
Cc:	Florian Westphal <fw@...len.de>,
	Zhouyi Zhou <zhouzhouyi@...il.com>, pablo@...filter.org,
	kaber@...sh.net, kadlec@...ckhole.kfki.hu, davem@...emloft.net,
	netfilter-devel@...r.kernel.org, coreteam@...filter.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	jbaron@...mai.com
Subject: Re: [PATCH 1/1] netfilter/jump_label: use HAVE_JUMP_LABEL?

Zhouyi Zhou <yizhouzhou@....ac.cn> wrote:
> > > 
> > > CONFIG_JUMP_LABEL doesn't ensure HAVE_JUMP_LABEL, if it
> > > is not the case use maintainers's own mutex to guard
> > > the modification of global values.
> 
> CONFIG_JUMP_LABEL says the user wants to use jump labels.
> But we also need the toolchain to support it.
> 
> That is reflected in CC_HAVE_ASM_GOTO=y, and if both are
> set then HAVE_JUMP_LABEL is set to true.

Please resubmit and update the changelog to reflect this,
e.g. add something like

Use HAVE_JUMP_LABEL as elsewhere in the kernel to ensure
that the toolchain has the required support in addition to
CONFIG_JUMP_LABEL being set.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html