lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 21 Aug 2014 09:56:13 -0700 From: Florian Fainelli <f.fainelli@...il.com> To: Jiri Pirko <jiri@...nulli.us> Cc: netdev <netdev@...r.kernel.org>, David Miller <davem@...emloft.net>, Neil Horman <nhorman@...driver.com>, Andy Gospodarek <andy@...yhouse.net>, tgraf <tgraf@...g.ch>, dborkman <dborkman@...hat.com>, ogerlitz <ogerlitz@...lanox.com>, jesse <jesse@...ira.com>, pshelar <pshelar@...ira.com>, azhou <azhou@...ira.com>, Ben Hutchings <ben@...adent.org.uk>, Stephen Hemminger <stephen@...workplumber.org>, Jeff Kirsher <jeffrey.t.kirsher@...el.com>, vyasevic <vyasevic@...hat.com>, Cong Wang <xiyou.wangcong@...il.com>, John Fastabend <john.r.fastabend@...el.com>, Eric Dumazet <edumazet@...gle.com>, Jamal Hadi Salim <jhs@...atatu.com>, Scott Feldman <sfeldma@...ulusnetworks.com>, Roopa Prabhu <roopa@...ulusnetworks.com>, John Linville <linville@...driver.com>, dev <dev@...nvswitch.org>, "jasowang@...hat.com" <jasowang@...hat.com>, "Eric W. Biederman" <ebiederm@...ssion.com>, Nicolas Dichtel <nicolas.dichtel@...nd.com>, Sergey Ryazanov <ryazanov.s.a@...il.com>, Lennert Buytenhek <buytenh@...tstofly.org>, Aviad Raveh <aviadr@...lanox.com>, Felix Fietkau <nbd@...nwrt.org>, Alexei Starovoitov <alexei.starovoitov@...il.com>, Neil Jerram <Neil.Jerram@...aswitch.com>, ronye@...lanox.com Subject: Re: [patch net-next RFC 07/12] dsa: implement ndo_swdev_get_id 2014-08-21 9:19 GMT-07:00 Jiri Pirko <jiri@...nulli.us>: > Signed-off-by: Jiri Pirko <jiri@...nulli.us> > --- > net/dsa/Kconfig | 2 +- > net/dsa/slave.c | 16 ++++++++++++++++ > 2 files changed, 17 insertions(+), 1 deletion(-) > > diff --git a/net/dsa/Kconfig b/net/dsa/Kconfig > index f5eede1..66c445a 100644 > --- a/net/dsa/Kconfig > +++ b/net/dsa/Kconfig > @@ -1,6 +1,6 @@ > config HAVE_NET_DSA > def_bool y > - depends on NETDEVICES && !S390 > + depends on NETDEVICES && NET_SWITCHDEV && !S390 > > # Drivers must select NET_DSA and the appropriate tagging format > > diff --git a/net/dsa/slave.c b/net/dsa/slave.c > index 45a1e34..e069ba3 100644 > --- a/net/dsa/slave.c > +++ b/net/dsa/slave.c > @@ -171,6 +171,19 @@ static int dsa_slave_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) > return -EOPNOTSUPP; > } > > +static int dsa_slave_swdev_get_id(struct net_device *dev, > + struct netdev_phys_item_id *psid) > +{ > + struct dsa_slave_priv *p = netdev_priv(dev); > + struct dsa_switch *ds = p->parent; > + u64 tmp = (u64) ds; > + > + /* TODO: add more sophisticated id generation */ > + memcpy(&psid->id, &tmp, sizeof(tmp)); > + psid->id_len = sizeof(tmp); There is already an unique id generated, which is the index in the switch tree, and which is stored in struct dsa_switch, so this could probably be simplified to: psid->id = ds->index -- Florian -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists