netdev - Re: [PATCH] phylib: use MDIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 22 Aug 2014 13:41:38 -0700
From:	Florian Fainelli <f.fainelli@...il.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] phylib: use MDIO_DEVS[12]

2014-08-22 12:56 GMT-07:00 Sergei Shtylyov <sergei.shtylyov@...entembedded.com>:
> The bare register numbers are used despite <uapi/linux/mdio.h> has MDIO_DEVS[12]
> #define'd for those.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>

Acked-by: Florian Fainelli <f.fainelli@...il.com>

>
> ---
> This patch is against DaveM's 'net-next.git' repo.
>
>  drivers/net/phy/phy_device.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: net-next/drivers/net/phy/phy_device.c
> ===================================================================
> --- net-next.orig/drivers/net/phy/phy_device.c
> +++ net-next/drivers/net/phy/phy_device.c
> @@ -230,13 +230,13 @@ static int get_phy_c45_ids(struct mii_bu
>         for (i = 1;
>              i < num_ids && c45_ids->devices_in_package == 0;
>              i++) {
> -               reg_addr = MII_ADDR_C45 | i << 16 | 6;
> +               reg_addr = MII_ADDR_C45 | i << 16 | MDIO_DEVS2;
>                 phy_reg = mdiobus_read(bus, addr, reg_addr);
>                 if (phy_reg < 0)
>                         return -EIO;
>                 c45_ids->devices_in_package = (phy_reg & 0xffff) << 16;
>
> -               reg_addr = MII_ADDR_C45 | i << 16 | 5;
> +               reg_addr = MII_ADDR_C45 | i << 16 | MDIO_DEVS1;
>                 phy_reg = mdiobus_read(bus, addr, reg_addr);
>                 if (phy_reg < 0)
>                         return -EIO;
>



-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html