lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 22 Aug 2014 08:13:40 -0400 From: Neil Horman <nhorman@...driver.com> To: Daniel Borkmann <dborkman@...hat.com> Cc: davem@...emloft.net, netdev@...r.kernel.org, linux-sctp@...r.kernel.org Subject: Re: [PATCH net 1/2] net: sctp: spare unnecessary comparison in sctp_trans_elect_best On Fri, Aug 22, 2014 at 01:03:29PM +0200, Daniel Borkmann wrote: > When both transports are the same, we don't have to go down that > road only to realize that we will return the very same transport. > We are guaranteed that curr is always non-NULL. Therefore, just > short-circuit this special case. > > Signed-off-by: Daniel Borkmann <dborkman@...hat.com> > --- > net/sctp/associola.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/sctp/associola.c b/net/sctp/associola.c > index aaafb32..104fae4 100644 > --- a/net/sctp/associola.c > +++ b/net/sctp/associola.c > @@ -1245,7 +1245,7 @@ static struct sctp_transport *sctp_trans_elect_best(struct sctp_transport *curr, > { > u8 score_curr, score_best; > > - if (best == NULL) > + if (best == NULL || curr == best) > return curr; > > score_curr = sctp_trans_score(curr); Acked-by: Neil Horman <nhorman@...driver.com> > -- > 1.7.11.7 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-sctp" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists