netdev - Re: [PATCH net] bnx2x: Revert UNDI flushing mechanism

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140821.175532.2001740724595557372.davem@davemloft.net>
Date:	Thu, 21 Aug 2014 17:55:32 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	Yuval.Mintz@...gic.com
Cc:	netdev@...r.kernel.org, Ariel.Elior@...gic.com
Subject: Re: [PATCH net] bnx2x: Revert UNDI flushing mechanism

From: Yuval Mintz <Yuval.Mintz@...gic.com>
Date: Mon, 18 Aug 2014 22:36:23 +0300

> Commit 91ebb929b6f8 ("bnx2x: Add support for Multi-Function UNDI") [which was
> later supposedly fixed by de682941eef3 ("bnx2x: Fix UNDI driver unload")]
> introduced a bug in which in some [yet-to-be-determined] scenarios the
> alternative flushing mechanism which was to guarantee the Rx buffers are
> empty before resetting them during device probe will fail.
> If this happens, when device will be loaded once more a fatal attention will
> occur; Since this most likely happens in boot from SAN scenarios, the machine
> will fail to load.
> 
> Notice this may occur not only in the 'Multi-Function' scenario but in the
> regular scenario as well, i.e., this introduced a regression in the driver's
> ability to perform boot from SAN.
> 
> The patch reverts the mechanism and applies the old scheme to multi-function
> devices as well as to single-function devices.
> 
> Signed-off-by: Yuval Mintz <Yuval.Mintz@...gic.com>
> Signed-off-by: Ariel Elior <Ariel.Elior@...gic.com>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html