netdev - Re: [RFC] net: ipv4: drop unicast encapsulated in L2 multicast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140822.105405.1982870131653082781.davem@davemloft.net>
Date:	Fri, 22 Aug 2014 10:54:05 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ja@....bg
Cc:	johannes@...solutions.net, linux-wireless@...r.kernel.org,
	netdev@...r.kernel.org, johannes.berg@...el.com
Subject: Re: [RFC] net: ipv4: drop unicast encapsulated in L2 multicast

From: Julian Anastasov <ja@....bg>
Date: Thu, 21 Aug 2014 22:51:02 +0300 (EEST)

>>  	if (res.type == RTN_BROADCAST)
>>  		goto brd_input;
> 
> 	Is this place better, after checking for RTN_BROADCAST?
> 
> 	/* ARP link-layer broadcasts are acceptable here */
> 	if ((skb->pkt_type == PACKET_BROADCAST ||
> 	     skb->pkt_type == PACKET_MULTICAST) &&
> 	    skb->protocol == htons(ETH_P_IP))
> 		goto e_inval;

Indeed, this would make ARP happier, but that still leaves open the
issue of CLUSTERIP.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html