netdev - Re: [PATCH net] openvswitch: fix panic with multiple vlan headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140822.112439.1786666004917748552.davem@davemloft.net>
Date:	Fri, 22 Aug 2014 11:24:39 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jbenc@...hat.com
Cc:	netdev@...r.kernel.org, dev@...nvswitch.org
Subject: Re: [PATCH net] openvswitch: fix panic with multiple vlan headers

From: Jiri Benc <jbenc@...hat.com>
Date: Thu, 21 Aug 2014 21:33:44 +0200

> When there are multiple vlan headers present in a received frame, the first
> one is put into vlan_tci and protocol is set to ETH_P_8021Q. Anything in the
> skb beyond the VLAN TPID may be still non-linear, including the inner TCI
> and ethertype. While ovs_flow_extract takes care of IP and IPv6 headers, it
> does nothing with ETH_P_8021Q. Later, if OVS_ACTION_ATTR_POP_VLAN is
> executed, __pop_vlan_tci pulls the next vlan header into vlan_tci.
> 
> This leads to two things:
> 
> 1. Part of the resulting ethernet header is in the non-linear part of the
>    skb. When eth_type_trans is called later as the result of
>    OVS_ACTION_ATTR_OUTPUT, kernel BUGs in __skb_pull. Also, __pop_vlan_tci
>    is in fact accessing random data when it reads past the TPID.
> 
> 2. network_header points into the ethernet header instead of behind it.
>    mac_len is set to a wrong value (10), too.
> 
> Reported-by: Yulong Pei <ypei@...hat.com>
> Signed-off-by: Jiri Benc <jbenc@...hat.com>

Applied and queued up for -stable, thanks Jiri.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html