lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:	Fri, 22 Aug 2014 22:14:31 +0300
From:	Andreea-Cristina Bernat <>
Subject: [PATCH v2] carl9170: Remove redundant protection check

The carl9170_op_ampdu_action() function is used only by the mac80211
Since the mac80211 already takes care of checks and properly serializing
calls to the driver's function there is no need for the driver to do the same

Signed-off-by: Andreea-Cristina Bernat <>
Changes in v2:
 - Change subject line from
   "carl9170: Replace rcu_dereference() with rcu_access_pointer()"
   "carl9170: Remove redundant protection check"
 - Update the commit message according to the modifications
 - Delete the lines of interest at the suggestion and explanations of
   Christian Lamparter <>

 drivers/net/wireless/ath/carl9170/main.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/net/wireless/ath/carl9170/main.c b/drivers/net/wireless/ath/carl9170/main.c
index 12018ff..6758b9a 100644
--- a/drivers/net/wireless/ath/carl9170/main.c
+++ b/drivers/net/wireless/ath/carl9170/main.c
@@ -1430,12 +1430,6 @@ static int carl9170_op_ampdu_action(struct ieee80211_hw *hw,
 		if (!sta_info->ht_sta)
 			return -EOPNOTSUPP;
-		rcu_read_lock();
-		if (rcu_access_pointer(sta_info->agg[tid])) {
-			rcu_read_unlock();
-			return -EBUSY;
-		}
 		tid_info = kzalloc(sizeof(struct carl9170_sta_tid),
 		if (!tid_info) {

To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists