netdev - Re: [PATCH net-next] tcp: improve undo on timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140822.212818.342424006799582674.davem@davemloft.net>
Date:	Fri, 22 Aug 2014 21:28:18 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ycheng@...gle.com
Cc:	ncardwell@...gle.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] tcp: improve undo on timeout

From: Yuchung Cheng <ycheng@...gle.com>
Date: Fri, 22 Aug 2014 14:15:22 -0700

> Upon timeout, undo (via both timestamps/Eifel and DSACKs) was
> disabled if any retransmits were still in flight.  The concern was
> perhaps that spurious retransmission sent in a previous recovery
> episode may trigger DSACKs to falsely undo the current recovery.
> 
> However, this inadvertently misses undo opportunities (using either
> TCP timestamps or DSACKs) when timeout occurs during a loss episode,
> i.e.  recurring timeouts or timeout during fast recovery. In these
> cases some retransmissions will be in flight but we should allow
> undo. Furthermore, we should only reset undo_marker and undo_retrans
> upon timeout if we are starting a new recovery episode. Finally,
> when we do reset our undo state, we now do so in a manner similar
> to tcp_enter_recovery(), so that we require a DSACK for each of
> the outstsanding retransmissions. This will achieve the original
> goal by requiring that we receive the same number of DSACKs as
> retransmissions.
> 
> This patch increases the undo events by 50% on Google servers.
> 
> Signed-off-by: Yuchung Cheng <ycheng@...gle.com>
> Signed-off-by: Neal Cardwell <ncardwell@...gle.com>

Looks good, applied, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html