netdev - Re: [PATCH net-next v3 08/12] net: dsa: allow updating fixed PHY link information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53FB8F84.20208@cogentembedded.com>
Date:	Mon, 25 Aug 2014 23:33:24 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Florian Fainelli <f.fainelli@...il.com>, netdev@...r.kernel.org
CC:	davem@...emlof.net, jhs@...atatu.com, linville@...driver.com,
	alexander.h.duyck@...el.com
Subject: Re: [PATCH net-next v3 08/12] net: dsa: allow updating fixed PHY
 link information

Hello.

On 08/24/2014 10:44 PM, Florian Fainelli wrote:

> Allow switch drivers to hook a PHY link update callback to perform
> port-specific link work.

> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>

[...]

> diff --git a/net/dsa/slave.c b/net/dsa/slave.c
> index 893afe9e60aa..ee019ec29dec 100644
> --- a/net/dsa/slave.c
> +++ b/net/dsa/slave.c
[...]
> @@ -389,6 +401,7 @@ static void dsa_slave_phy_setup(struct dsa_slave_priv *p,
>   	struct dsa_switch *ds = p->parent;
>   	struct dsa_chip_data *cd = ds->pd;
>   	struct device_node *phy_dn, *port_dn;
> +	unsigned int phy_is_fixed = 0;

    Why not *bool*?

[...]

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html