netdev - Re: [PATCH net-next] bpf: x86: add missing 'shift by register' instructions to x64 eBPF JIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMEtUuzGYPc82NoaGzSs3sFve3C0oWGxnZ5yYjtFTcPc0pmsnw@mail.gmail.com>
Date:	Mon, 25 Aug 2014 12:43:24 -0700
From:	Alexei Starovoitov <ast@...mgrid.com>
To:	Daniel Borkmann <dborkman@...hat.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Brendan Gregg <brendan.d.gregg@...il.com>,
	Network Development <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] bpf: x86: add missing 'shift by register'
 instructions to x64 eBPF JIT

On Mon, Aug 25, 2014 at 12:39 PM, Daniel Borkmann <dborkman@...hat.com> wrote:
> On 08/25/2014 09:27 PM, Alexei Starovoitov wrote:
>>
>> 'shift by register' operations are supported by eBPF interpreter, but were
>> accidently left out of x64 JIT compiler. Fix it and add a testcase.
>>
>> Reported-by: Brendan Gregg <brendan.d.gregg@...il.com>
>> Signed-off-by: Alexei Starovoitov <ast@...mgrid.com>
>> Fixes: 622582786c9e ("net: filter: x86: internal BPF JIT")
>> ---
>>
>> Probably not worth sending to stable, but wouldn't hurt either.
>
>
> Then I guess this should be against -net tree then.
>
> I guess implications were only fallback to interpreter, right?

yes. it falls back to interpreter and works fine.
I'm not sure it's worth sending to stable that's why I went with net-next.
Technically it's half missing feature and half bug.
It feels more of missing feature to me.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html