netdev - Re: [PATCH net-next] r8152: check code with checkpatch.pl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 25 Aug 2014 12:58:52 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	hayeswang@...ltek.com
Cc:	netdev@...r.kernel.org, nic_swsd@...ltek.com,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH net-next] r8152: check code with checkpatch.pl

From: Hayes Wang <hayeswang@...ltek.com>
Date: Mon, 25 Aug 2014 15:53:00 +0800

>  626: CHECK: Alignment should match open parenthesis
>  646: CHECK: Alignment should match open parenthesis
>  655: CHECK: Alignment should match open parenthesis
>  695: CHECK: Alignment should match open parenthesis
>  729: CHECK: Alignment should match open parenthesis
>  739: CHECK: Alignment should match open parenthesis
>  976: WARNING: externs should be avoided in .c files
>  1314: CHECK: Alignment should match open parenthesis
>  1358: WARNING: networking block comments don't use an empty /* line, use /* Comment...
>  1402: WARNING: networking block comments don't use an empty /* line, use /* Comment...
>  1521: CHECK: multiple assignments should be avoided
>  1775: CHECK: Alignment should match open parenthesis
>  1838: CHECK: multiple assignments should be avoided
>  1843: CHECK: multiple assignments should be avoided
>  1847: CHECK: multiple assignments should be avoided
>  1850: WARNING: Missing a blank line after declarations
>  1864: CHECK: Alignment should match open parenthesis
>  1872: CHECK: braces {} should be used on all arms of this statement
>  1906: CHECK: usleep_range is preferred over udelay
>  2865: WARNING: networking block comments don't use an empty /* line, use /* Comment...
>  3088: CHECK: Alignment should match open parenthesis
>  total: 0 errors, 5 warnings, 16 checks, 3567 lines checked
> 
> Signed-off-by: Hayes Wang <hayeswang@...ltek.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html