netdev - Re: [patch net-next] team: set IFF_TEAM_PORT priv_flag after rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHA+R7NeOhhHu+RJ-zyOt_3PrY7qYk98r7gjH9Qz3Vf=Za_REA@mail.gmail.com>
Date:	Mon, 25 Aug 2014 14:11:15 -0700
From:	Cong Wang <cwang@...pensource.com>
To:	Jiri Pirko <jiri@...nulli.us>
Cc:	netdev <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>, fbl@...hat.com,
	erik.hugne@...csson.com
Subject: Re: [patch net-next] team: set IFF_TEAM_PORT priv_flag after
 rx_handler is registered

On Mon, Aug 25, 2014 at 12:38 PM, Jiri Pirko <jiri@...nulli.us> wrote:
> When one tries to add eth as a port into team and that eth is already in
> use by other rx_handler device (macvlan, bond, bridge, ...) a bug in
> team_port_add() causes that IFF_TEAM_PORT flag is set before rx_handler
> is registered. In between, netdev nofifier is called and
> team_device_event() sees IFF_TEAM_PORT and thinks that rx_handler_data
> pointer is set to team_port. But it isn't.
>
> Fix this by reordering rx_handler register and IFF_TEAM_PORT priv flag
> set so it is very similar to how bonding does this.
>
> Reported-by: Erik Hugne <erik.hugne@...csson.com>
> Introduced-by: 3d249d4ca7 "net: introduce ethernet teaming device"
> Signed-off-by: Jiri Pirko <jiri@...nulli.us>

For consistence, we use "Fixes:" instead of "Introduced-by:".
Just fyi.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html