netdev - Fw: [Bug 83131] New: can: ti_hecc.c: closing device while receiving can messages, effectively disables all socket transfer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20140825144507.09c952cf@urahara>
Date:	Mon, 25 Aug 2014 14:45:07 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	netdev@...r.kernel.org
Subject: Fw: [Bug 83131] New: can: ti_hecc.c: closing device while receiving
 can messages, effectively disables all socket transfer



Begin forwarded message:

Date: Sun, 24 Aug 2014 06:07:49 -0700
From: "bugzilla-daemon@...zilla.kernel.org" <bugzilla-daemon@...zilla.kernel.org>
To: "stephen@...workplumber.org" <stephen@...workplumber.org>
Subject: [Bug 83131] New: can: ti_hecc.c: closing device while receiving can messages, effectively disables all socket transfer


https://bugzilla.kernel.org/show_bug.cgi?id=83131

            Bug ID: 83131
           Summary: can: ti_hecc.c: closing device while receiving can
                    messages, effectively disables all socket transfer
           Product: Networking
           Version: 2.5
    Kernel Version: 3.16.1
          Hardware: All
                OS: Linux
              Tree: PREEMPT_RT
            Status: NEW
          Severity: normal
          Priority: P1
         Component: Other
          Assignee: shemminger@...ux-foundation.org
          Reporter: jan.sondhauss@...il.com
        Regression: No

drivers/net/can/ti_hecc.c:

When closing the can device, its not ensured that it gets removed from the
socket-poll list.

The problem here lies in the ti_hecc_rx_poll() function which returns early
when the device is closed already.
This leads to napi_complete() never being called, thus the device stays in the
napi's poll list forever and every task reading from any socket is polling this
device. The system is now basically unreachable.

The patch attached seams to fix this problem by removing the early return in
the ti_hecc_rx_poll function. But I'm not sure whether this is the correct
solution.

-- 
You are receiving this mail because:
You are the assignee for the bug.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html