netdev - Re: [PATCH net-next 1/2] net: Header length compution function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53FBB702.8080905@intel.com>
Date:	Mon, 25 Aug 2014 15:21:54 -0700
From:	Alexander Duyck <alexander.h.duyck@...el.com>
To:	David Miller <davem@...emloft.net>
CC:	eric.dumazet@...il.com, amirv@...lanox.com, netdev@...r.kernel.org,
	ogerlitz@...lanox.com, yevgenyp@...lanox.com, idos@...lanox.com,
	Tom Herbert <therbert@...gle.com>
Subject: Re: [PATCH net-next 1/2] net: Header length compution function

On 08/23/2014 12:19 PM, David Miller wrote:
> From: Alexander Duyck <alexander.h.duyck@...el.com>
> Date: Thu, 31 Jul 2014 08:34:22 -0700
> 
>> On 07/30/2014 06:39 PM, David Miller wrote:
>>> I don't think my proposed patch is a bad trade off.  Where we have the
>>> __skb_header_pointer() thing that takes preloaded pointers and header
>>> length values.  It adds only one test which frankly should never
>>> trigger and can be moved down into skb_copy_bits() or similar.
>>
>> This works for me.  Once it is in I can see about pushing a patch to add
>> some FCoE support and work on moving over igb and ixgbe.
> 
> You should be able to do this against net-next now, just FYI.
> 

Actually I was just looking at the code.  It looks like commit
19469a873bafd4e65daef3597db2bd724c1b03c9 "flow_dissector: Use IPv6 flow
label in flow_dissector" is likely breaking things in terms of trying to
use this function to get the header length since the code now returns
early if an IPv6 flow label is present.

Thanks,

Alex


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html