lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 25 Aug 2014 15:41:24 -0700 (PDT) From: David Miller <davem@...emloft.net> To: eric.dumazet@...il.com Cc: cwang@...pensource.com, netdev@...r.kernel.org, therbert@...gle.com, jhs@...atatu.com, hannes@...essinduktion.org, edumazet@...gle.com, jeffrey.t.kirsher@...el.com, rusty@...tcorp.com.au Subject: Re: [PATCH 0/3] Basic deferred TX queue flushing infrastructure. From: Eric Dumazet <eric.dumazet@...il.com> Date: Mon, 25 Aug 2014 15:37:54 -0700 > On Mon, 2014-08-25 at 15:31 -0700, David Miller wrote: > >> It occurs to me that perhaps the thing to do is to pass sk_buff ** to >> dev_hard_start_xmit(). > > This was my suggestion ;) > > int ret = dev_hard_start_xmit(skb, dev, txq); > > -> > > int ret = dev_hard_start_xmit(&skb, dev, txq); Ok and this can solve the GSO freeing issue too, if the caller was working with a segmented SKB, he can pass &skb->next to dev_hard_start_xmit() then if skb->next is NULL after dev_hard_start_xmit() returns we can free up the head GSO skb. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists