netdev - Re: [PATCH v2 net-next 0/6] net: Checksum offload changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140824.182450.1565360550397265947.davem@davemloft.net>
Date:	Sun, 24 Aug 2014 18:24:50 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	therbert@...gle.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next 0/6] net: Checksum offload changes - Part V 

From: Tom Herbert <therbert@...gle.com>
Date: Fri, 22 Aug 2014 13:33:38 -0700 (PDT)

> I am working on overhauling RX checksum offload. Goals of this effort
> are:
> 
> - Specify what exactly it means when driver returns CHECKSUM_UNNECESSARY
> - Preserve CHECKSUM_COMPLETE through encapsulation layers
> - Don't do skb_checksum more than once per packet
> - Unify GRO and non-GRO csum verification as much as possible
> - Unify the checksum functions (checksum_init)
> - Simplify code
> 
> What is in this fifth patch set:
> 
> - Added GRO checksum validation functions
> - Call the GRO validations functions from TCP and GRE gro_receive
> - Perform checksum verification in the UDP gro_receive path using
>   GRO functions and add support for gro_receive in UDP6
> 
> Changes in V2:
> 
> - Change ip_summed to CHECKSUM_UNNECESSARY instead of moving it
>   to CHECKSUM_COMPLETE from GRO checksum validation. This avoids
>   performance penalty in checksumming bytes which are before the header
>   GRO is at.
> 
> Please review carefully and test if possible, mucking with basic
> checksum functions is always a little precarious :-)

Looks good, applied, thanks Tom.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html