lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20140825.161438.1566152288868625745.davem@davemloft.net> Date: Mon, 25 Aug 2014 16:14:38 -0700 (PDT) From: David Miller <davem@...emloft.net> To: cwang@...pensource.com Cc: amirv@...lanox.com, alexander.h.duyck@...el.com, netdev@...r.kernel.org, ogerlitz@...lanox.com, yevgenyp@...lanox.com, idos@...lanox.com, eric.dumazet@...il.com Subject: Re: [PATCH] net: Allow raw buffers to be passed into the flow dissector. From: Cong Wang <cwang@...pensource.com> Date: Mon, 25 Aug 2014 16:13:01 -0700 > On Sat, Aug 23, 2014 at 12:18 PM, David Miller <davem@...emloft.net> wrote: >> diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c >> index 5f362c1..660c649 100644 >> --- a/net/core/flow_dissector.c >> +++ b/net/core/flow_dissector.c >> @@ -34,29 +34,40 @@ static void iph_to_flow_copy_addrs(struct flow_keys *flow, const struct iphdr *i >> * The function will try to retrieve the ports at offset thoff + poff where poff >> * is the protocol port offset returned from proto_ports_offset >> */ >> -__be32 skb_flow_get_ports(const struct sk_buff *skb, int thoff, u8 ip_proto) >> +__be32 __skb_flow_get_ports(const struct sk_buff *skb, int thoff, u8 ip_proto, >> + void *data, int hlen) > > > You forgot to update the comments above __skb_flow_get_ports(), > not a big deal, I will send a patch if you don't. ;-) Please do, thanks. > Not sure if I read your patch correctly, I think our goal is to make > skb parameter > optional so that callers can pass NULL if they don't have a skb struct? > __skb_flow_dissect() still refers skb->protocol at least. The idea is that explicit *data and hlen can be provided in absense of an SKB. I see the skb->protocol reference, I guess we'll need to provide an explicit protocol argument as well, good catch! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists