netdev - Re: using rhashtable in inethash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140825.163645.1024070177356241101.davem@davemloft.net>
Date:	Mon, 25 Aug 2014 16:36:45 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	tgraf@...g.ch
Cc:	eric.dumazet@...il.com, netdev@...r.kernel.org,
	paulmck@...ux.vnet.ibm.com
Subject: Re: using rhashtable in inethash

From: Thomas Graf <tgraf@...g.ch>
Date: Tue, 26 Aug 2014 00:33:46 +0100

> The reason I added added the sync is because I could not see how
> else to prevent the sock_put() in netlink_release() to release
> socket memoray, specifically the embedded rhash_head, that is
> possibly being accessed in a RCU protected reader traversing the
> bucket. Such a reader would not hold a reference to the socket.
> I may be missing something though and I'm happy to change this for
> something better.

Ok, this is going to be a tree-wide issue where we try to use
rhashtable with sockets of any type.

Perhaps we're overdue for RCU freeing of sockets, but that added
noticable latency last time I tried it.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html