netdev - Re: [hyperv] BUG at drivers/hv/channel.c:462 while changing MTU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140825093648.GB5046@mwanda>
Date:	Mon, 25 Aug 2014 12:36:48 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Sitsofe Wheeler <sitsofe@...il.com>
Cc:	"K. Y. Srinivasan" <kys@...rosoft.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jason Wang <jasowang@...hat.com>, linux-kernel@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>,
	Daniel Borkmann <dborkman@...hat.com>, netdev@...r.kernel.org,
	devel@...uxdriverproject.org,
	Haiyang Zhang <haiyangz@...rosoft.com>
Subject: Re: [hyperv] BUG at drivers/hv/channel.c:462 while changing MTU

The code here is:

drivers/hv/channel.c
   460          BUG_ON(ret != 0);
   461          t = wait_for_completion_timeout(&info->waitevent, 5*HZ);
   462          BUG_ON(t == 0);

So it calls BUG_ON() if the teardown takes more than 5 seconds.  It's
most likely that there is a race condition somewhere.  It's also
possible that it's just taking longer than 5 seconds for some odd
reason and the bug would go away if we raised it to 60 seconds.

BUG_ON() after 5 seconds seems like a very aggressive thing.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html