netdev - Re: [PATCH v3 3/3] ethernet: arc: Add support for specific SoC glue layer device tree bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6043486.sQSNjC9EMf@wuerfel>
Date:	Tue, 26 Aug 2014 11:44:17 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Romain Perier <romain.perier@...il.com>
Cc:	davem@...emloft.net, heiko@...ech.de, tklauser@...tanz.ch,
	b.galvani@...il.com, eric.dumazet@...il.com,
	yongjun_wei@...ndmicro.com.cn, f.fainelli@...il.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH v3 3/3] ethernet: arc: Add support for specific SoC glue layer device tree bindings

The code changes all look good in this version, but the Kconfig and changelog
are not yet perfect:

On Tuesday 26 August 2014 09:23:52 Romain Perier wrote:
> Some platforms have special bank registers which might be used to select
> the correct clock or the right mode for Media Indepent Interface controllers.
> Sometimes, it is also required to activate vcc regulators in the right order to supply
> the ethernet controller at the right time. This patch is an architecture refactoring
> of the arc-emac device driver. it adds a new software design which allows to add specific
> platform glue layer. Each platform has now its own module which performs custom initialization
> and remove for the target and then calls to the core driver.

Please restrict the changelog line width to something like 70 characters

> diff --git a/drivers/net/ethernet/arc/Kconfig b/drivers/net/ethernet/arc/Kconfig
> index 514c57f..e193826 100644
> --- a/drivers/net/ethernet/arc/Kconfig
> +++ b/drivers/net/ethernet/arc/Kconfig
> @@ -17,12 +17,16 @@ config NET_VENDOR_ARC
>  
>  if NET_VENDOR_ARC
>  
> -config ARC_EMAC
> -	tristate "ARC EMAC support"
> +config ARC_EMAC_CORE
> +	bool

This should be 'tristate', so you can build it as a loadable module
when ARC_EMAC is also a module. Kconfig will ensure it is set to 'y'
if any other built-in driver selects it, or to 'm' if it is selected
only by drivers that are also modules.

>  	select MII
>  	select PHYLIB
>  	depends on OF_IRQ
>  	depends on OF_NET
> +
> +config ARC_EMAC
> +	tristate "ARC EMAC support"
> +	select ARC_EMAC_CORE

The 'depends on' lines need to be moved below, otherwise you can still
enable ARC_EMAC if OF_IRQ and OF_NET are disabled.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html