lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <53FC5DCF.4060202@st.com> Date: Tue, 26 Aug 2014 12:13:35 +0200 From: Giuseppe CAVALLARO <peppe.cavallaro@...com> To: Ley Foon Tan <lftan@...era.com>, <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>, "David S. Miller" <davem@...emloft.net> Cc: <lftan.linux@...il.com>, Vince Bridgers <vbridger@...era.com> Subject: Re: [PATCH (net-next) v2] net: stmmac: fix warning from Sparse for socfpga On 8/26/2014 11:47 AM, Ley Foon Tan wrote: > Warning: > drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c:122:41: > sparse: cast removes address space of expression > drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c:122:38: > sparse: incorrect type in assignment (different address spaces) > > Signed-off-by: Ley Foon Tan <lftan@...era.com> > --- > drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c > index cd613d7..ff54a1f 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c > @@ -119,7 +119,7 @@ static int socfpga_dwmac_parse_data(struct socfpga_dwmac *dwmac, struct device * > return -EINVAL; > } > > - dwmac->splitter_base = (void *)devm_ioremap_resource(dev, > + dwmac->splitter_base = devm_ioremap_resource(dev, > &res_splitter); can the ioremap call stay in a single line ? or pls review indent looks NOK peppe > if (!dwmac->splitter_base) { > dev_info(dev, "Failed to mapping emac splitter\n"); > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists