netdev - RE: [PATCH v2 net-next 2/2] tipc: add name distributor resiliency queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <A2BAEFC30C8FD34388F02C9B3121859D1C2BF752@eusaamb103.ericsson.se>
Date:	Tue, 26 Aug 2014 14:44:34 +0000
From:	Jon Maloy <jon.maloy@...csson.com>
To:	Erik Hugne <erik.hugne@...csson.com>,
	"ying.xue@...driver.com" <ying.xue@...driver.com>,
	Richard Alpe <richard.alpe@...csson.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:	"tipc-discussion@...ts.sourceforge.net" 
	<tipc-discussion@...ts.sourceforge.net>
Subject: RE: [PATCH v2 net-next 2/2] tipc: add name distributor resiliency
 queue

(netdev removed from receiver list)

> -----Original Message-----
> From: Erik Hugne
> Sent: August-26-14 10:33 AM
> To: Jon Maloy; ying.xue@...driver.com; Richard Alpe;
> netdev@...r.kernel.org
> Cc: tipc-discussion@...ts.sourceforge.net
> Subject: Re: [PATCH v2 net-next 2/2] tipc: add name distributor resiliency
> queue
> 
> if (e->expiry > now) should in fact be
> if (time_after(e->expiry, now) to handle timer wraps correctly.
> 
> Thanks Niklas Söderlund for pointing this out.
> 
> v2 removed from patchwork
> 
> //E

Also, don't use the version label an comment when you send this
to David. This has only relevance to us who are reviewing the
series. (I assume it was  a mistake)

///jon

> 
> On Tue, Aug 26, 2014 at 10:57:57AM +0200, erik.hugne@...csson.com wrote:
> > +void tipc_named_process_backlog(void) {
> > +	struct distr_queue_item *e, *tmp;
> > +	char addr[16];
> > +	u64 now = get_jiffies_64();
> > +
> > +	list_for_each_entry_safe(e, tmp, &tipc_dist_queue, next) {
> > +		if (e->expiry > now) {
> > +			if (!tipc_update_nametbl(&e->i, e->node, e-
> >dtype))
> > +				continue;
> > +		} else {
> > +			tipc_addr_string_fill(addr, e->node);
> > +			pr_warn_ratelimited("Dropping name table update
> (%d) of {%u, %u, %u} from %s key=%u\n",
> > +					    e->dtype, ntohl(e->i.type),
> > +					    ntohl(e->i.lower),
> > +					    ntohl(e->i.upper),
> > +					    addr, ntohl(e->i.key));
> > +		}
> > +		list_del(&e->next);
> > +		kfree(e);
> > +	}
> > +}
> > +
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html