netdev - Re: [PATCH v2 net-next] net: Functions to report space available in device TX queues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+mtBx-KD6Yw=Bkeb39FPRxUiG4koxSFqGzP_1bViEUf+tj-sw@mail.gmail.com>
Date:	Tue, 26 Aug 2014 08:44:10 -0700
From:	Tom Herbert <therbert@...gle.com>
To:	David Miller <davem@...emloft.net>
Cc:	Linux Netdev List <netdev@...r.kernel.org>
Subject: Re: [PATCH v2 net-next] net: Functions to report space available in
 device TX queues

On Mon, Aug 25, 2014 at 5:33 PM, David Miller <davem@...emloft.net> wrote:
> From: Tom Herbert <therbert@...gle.com>
> Date: Mon, 25 Aug 2014 08:27:56 -0700 (PDT)
>
>> This patch adds netdev_tx_avail_queue and netdev_avail_queue which are
>> used to report number of bytes available in transmit queues per BQL. The
>> functions call dql_avail which returns BQL limit minus number of
>> inflight bytes. These functions can be called without txlock, for
>> instance to ascertain how much data should be dequeued from a qdisc in
>> a batch. When called without the tx_lock, the result is technically a
>> hint, subsequently when the tx_lock is done for a transmit it is
>> possible the availability has changed (for example a transmit
>> completion may have freed up more space in the queue or changed the
>> limit).
>>
>> Signed-off-by: Tom Herbert <therbert@...gle.com>
>
> Ok this looks fine, but could you please resubmit this alongside
> the first use case?
>
It should be called when determining the best size for a transmit
batch, e.g. how many bytes to dequeue from qdisc on wakeup.

> Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html