lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <53FCB4B0.10400@intel.com> Date: Tue, 26 Aug 2014 09:24:16 -0700 From: Alexander Duyck <alexander.h.duyck@...el.com> To: Daniel Borkmann <dborkman@...hat.com> CC: davem@...emloft.net, netdev@...r.kernel.org Subject: Re: [PATCH net-next] ixgbe: flush when in xmit_more mode and under descriptor pressure On 08/26/2014 09:21 AM, Daniel Borkmann wrote: > On 08/26/2014 06:01 PM, Alexander Duyck wrote: > ... >> My thought is to just fold ixgbe_maybe_stop_tx into the if statement. >> >> So it shoudl be: >> if (!skb->smit_more || ixgbe_maybe_stop_tx(tx_ring, DESC_NEEDED)) > > Right, that's better; I was just thinking about the DMA error case, > but in that case we release resources back anyway. Actually the order does need to be reversed though. We should test for stop_tx first, then xmit_more. Doing it the other way around would cause issues as maybe_stop_tx has some other side effects. Thaks, Alex -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists