netdev - Re: [PATCH net-next 1/8] net: Clarification of CHECKSUM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+mtBx8iv8tWU0mmEQEWxDfp614Hh=cQOpXqxSdhHaGsH6sBDA@mail.gmail.com>
Date:	Mon, 25 Aug 2014 18:40:48 -0700
From:	Tom Herbert <therbert@...gle.com>
To:	David Miller <davem@...emloft.net>
Cc:	Linux Netdev List <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 1/8] net: Clarification of CHECKSUM_UNNECESSARY

On Mon, Aug 25, 2014 at 6:13 PM, David Miller <davem@...emloft.net> wrote:
> From: Tom Herbert <therbert@...gle.com>
> Date: Mon, 25 Aug 2014 17:55:56 -0700 (PDT)
>
>> @@ -569,16 +590,13 @@ struct sk_buff {
>>       __u8                    wifi_acked:1;
>>       __u8                    no_fcs:1;
>>       __u8                    head_frag:1;
>> -     /* Encapsulation protocol and NIC drivers should use
>> -      * this flag to indicate to each other if the skb contains
>> -      * encapsulated packet or not and maybe use the inner packet
>> -      * headers if needed
>> -      */
>> +     /* Indicates the the inner headers are valid in the skbuff. */
>>       __u8                    encapsulation:1;
>>       __u8                    encap_hdr_csum:1;
>>       __u8                    csum_valid:1;
>>       __u8                    csum_complete_sw:1;
>> -     /* 2/4 bit hole (depending on ndisc_nodetype presence) */
>> +     __u8                    csum_level:2;
>> +     /* 0/2 bit hole (depending on ndisc_nodetype presence) */
>>       kmemcheck_bitfield_end(flags2);
>
> Crap, with xmit_more, this actually bleeds us over into a new __u8.

We'll undoubtably want to add more flags beyond that (they're quite
useful). I'll try to find some more space in the existing fields so we
don't increase skbuf size.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html