lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20140825.172615.1598002278628891621.davem@davemloft.net> Date: Mon, 25 Aug 2014 17:26:15 -0700 (PDT) From: David Miller <davem@...emloft.net> To: jonas.jensen@...il.com Cc: netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, f.fainelli@...il.com, eric.dumazet@...il.com, mirqus@...il.com Subject: Re: [PATCH v6 4/4] net: moxa: continue loop on skb allocation failure From: Jonas Jensen <jonas.jensen@...il.com> Date: Mon, 25 Aug 2014 16:22:40 +0200 > If netdev_alloc_skb_ip_align() fails, subsequent code will > try to dereference an invalid pointer. > > Continue to next descriptor on error. > > While we're at it, > > 1. eliminate the chance of an endless loop, replace the main > loop with while(rx < budget) > > 2. use napi_complete() and remove the explicit napi_gro_flush() > > Signed-off-by: Jonas Jensen <jonas.jensen@...il.com> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists