netdev - Re: [PATCH] net: rds: Don't allocate rds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140826065409.GT17528@sirena.org.uk>
Date:	Tue, 26 Aug 2014 07:54:09 +0100
From:	Mark Brown <broonie@...nel.org>
To:	David Miller <davem@...emloft.net>
Cc:	chien.yen@...cle.com, rds-devel@....oracle.com,
	netdev@...r.kernel.org, linaro-kernel@...ts.linaro.org
Subject: Re: [PATCH] net: rds: Don't allocate rds_sock on stack

On Mon, Aug 25, 2014 at 12:57:40PM -0700, David Miller wrote:
> From: Mark Brown <broonie@...nel.org>

> > From: Mark Brown <broonie@...aro.org>

> > struct rds_sock is rather large ausing the following warning in an ARM
> > allmodconfig:

> > net/rds/iw_rdma.c:200:1: warning: the frame size of 1056 bytes is larger than 1024 bytes [-Wframe-larger-than=]

> > Fix this by dynamically allocating struct rds_sock in rds_iw_update_cm_id
> > instead of allocating it on the stack.

> > Signed-off-by: Mark Brown <broonie@...aro.org>

> I'd like you to fix this differently.  Creating pseudo instances of
> objects, and partially initializing it, just to satisfy an interface
> is always a really bad sign.

> Create a key structure argument for rds_iw_get_device() and initialize that
> and pass it in instead, update the other caller similarly.

I agree that the existing code looks like it could be improved even more
but please bear in mind that I'm just looking for a clean build (we've
got less than 20 warnings in allmodconfig including staging at the
minute) rather than actively working on this code in particular - I've
no ability to do more than build testing here.

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)