netdev - Re: [PATCH] net: rds: Don't allocate rds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 27 Aug 2014 11:46:51 +0100
From:	Mark Brown <broonie@...nel.org>
To:	David Miller <davem@...emloft.net>
Cc:	chien.yen@...cle.com, rds-devel@....oracle.com,
	netdev@...r.kernel.org, linaro-kernel@...ts.linaro.org
Subject: Re: [PATCH] net: rds: Don't allocate rds_sock on stack

On Tue, Aug 26, 2014 at 08:29:06AM -0700, David Miller wrote:
> From: Mark Brown <broonie@...nel.org>

> > I agree that the existing code looks like it could be improved even more
> > but please bear in mind that I'm just looking for a clean build (we've
> > got less than 20 warnings in allmodconfig including staging at the
> > minute) rather than actively working on this code in particular - I've
> > no ability to do more than build testing here.

> I understand that, but please fix this bug properly.

Please set the expectation among the networking developers that their
code should compile cleanly on all architectures; currently the
networking code (mostly drivers rather than the core) is the single
biggest source of warnings outside of staging and if we are requring
things like this then that presents a substantial barrier to others
contributing to addressing the warnings.

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)