netdev - Re: [PATCH net-next] bonding: add slave_changelink support and use it for queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140827142957.GA1908@nanopsycho.lan>
Date:	Wed, 27 Aug 2014 16:29:57 +0200
From:	Jiri Pirko <jiri@...nulli.us>
To:	Nikolay Aleksandrov <nikolay@...hat.com>
Cc:	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	Jay Vosburgh <j.vosburgh@...il.com>,
	Veaceslav Falico <vfalico@...il.com>,
	Andy Gospodarek <andy@...yhouse.net>
Subject: Re: [PATCH net-next] bonding: add slave_changelink support and use
 it for queue_id

Wed, Aug 27, 2014 at 04:06:46PM CEST, nikolay@...hat.com wrote:
>This patch adds support for slave_changelink to the bonding and uses it
>to give the ability to change the queue_id of the enslaved devices via
>netlink. It sets slave_maxtype and uses bond_changelink as a prototype for
>bond_slave_changelink.
>Example/test command after the iproute2 patch:
> ip link set eth0 type bond_slave queue_id 10
>
>CC: David S. Miller <davem@...emloft.net>
>CC: Jay Vosburgh <j.vosburgh@...il.com>
>CC: Veaceslav Falico <vfalico@...il.com>
>CC: Andy Gospodarek <andy@...yhouse.net>
>
>Suggested-by: Jiri Pirko <jiri@...nulli.us>
>Signed-off-by: Nikolay Aleksandrov <nikolay@...hat.com>
>---
>note: I intend to add a new option flag to indicate it's a slave option
>      so a new netdev notifier can be called (NETDEV_CHANGESLAVEINFODATA).

	No need fo that atm.

>      I believe the bonding is the first user of slave_changelink so I hope
>      I haven't missed anything. Once this patch is accepted in some form
>      I'll post the iproute2 one.


This patch is looking good to me.

Acked-by: Jiri Pirko <jiri@...nulli.us>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html