Message-ID: <CALCETrXAfZJTsF2nPFw55rHkfbNXKQuF8Frnq3e1wHEoGxLM4w@mail.gmail.com>
Date:	Wed, 27 Aug 2014 11:26:18 -0700
From:	Andy Lutomirski <luto@...capital.net>
To:	Alexei Starovoitov <ast@...mgrid.com>
Cc:	Daniel Borkmann <dborkman@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Chema Gonzalez <chema@...gle.com>,
	Namhyung Kim <namhyung@...nel.org>,
	Eric Dumazet <edumazet@...gle.com>,
	"David S. Miller" <davem@...emloft.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Brendan Gregg <brendan.d.gregg@...il.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Network Development <netdev@...r.kernel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Kees Cook <keescook@...omium.org>,
	Linux API <linux-api@...r.kernel.org>,
	Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH RFC v7 net-next 00/28] BPF syscall

On Tue, Aug 26, 2014 at 9:57 PM, Alexei Starovoitov <ast@...mgrid.com> wrote:
> On Tue, Aug 26, 2014 at 9:49 PM, Andy Lutomirski <luto@...capital.net> wrote:
>> On Tue, Aug 26, 2014 at 9:35 PM, Alexei Starovoitov <ast@...mgrid.com> wrote:
>>> On Tue, Aug 26, 2014 at 8:56 PM, Andy Lutomirski <luto@...capital.net> wrote:
>>>> On Aug 26, 2014 7:29 PM, "Alexei Starovoitov" <ast@...mgrid.com> wrote:
>>>>>
>>>>> Hi Ingo, David,
>>>>>
>>>>> posting whole thing again as RFC to get feedback on syscall only.
>>>>> If syscall bpf(int cmd, union bpf_attr *attr, unsigned int size) is ok,
>>>>> I'll split them into small chunks as requested and will repost without RFC.
>>>>
>>>> IMO it's much easier to review a syscall if we just look at a
>>>> specification of what it does.  The code is, in some sense, secondary.
>>>
>>> 'specification of what it does'... hmm, you mean beyond what's
>>> there in commit logs and in Documentation/networking/filter.txt ?
>>> Aren't samples at the end give an idea on 'what it does'?
>>> I'm happy to add 'specification', I just don't understand yet what
>>> it suppose to talk about beyond what's already written.
>>> I understand that the patches are missing explanation on 'why'
>>> the syscall is being added, but I don't think it's what you're asking...
>>
>> I mean a hopefully short document that defines what the syscall does.
>> It should be precise enough that one could, in principle, implement
>> the syscall just by reading the document and that one could use the
>> syscall just by reading the document.
>>
>> Given that there's a whole instruction set to go with it, it may end
>> up being moderately complicated or saying things like "see this other
>> thing for a description of the instruction set" and "there are some
>> extensible sets of functions you can call with it".
>
> I'm still lost.
>
> Here is the quote from Documentation/networking/filter.txt
> "
> 'maps' is a generic storage of different types for sharing data between kernel
> and userspace.
>
> The maps are accessed from user space via BPF syscall,
> which has commands:
> - create a map with given type and attributes
>   map_fd = bpf(BPF_MAP_CREATE, union bpf_attr *attr, u32 size)
>   using attr->map_type, attr->key_size, attr->value_size, attr->max_entries
>   returns process-local file descriptor or negative error
>
> - lookup key in a given map
>   err = bpf(BPF_MAP_LOOKUP_ELEM, union bpf_attr *attr, u32 size)
>   using attr->map_fd, attr->key, attr->value
>   returns zero and stores found elem into value or negative error
>
> - create or update key/value pair in a given map
>   err = bpf(BPF_MAP_UPDATE_ELEM, union bpf_attr *attr, u32 size)
>   using attr->map_fd, attr->key, attr->value
>   returns zero or negative error
>
> - find and delete element by key in a given map
>   err = bpf(BPF_MAP_DELETE_ELEM, union bpf_attr *attr, u32 size)
>   using attr->map_fd, attr->key
>
> - to delete map: close(fd)
>   Exiting process will delete maps automatically
>
> userspace programs uses this API to create/populate/read
> maps that eBPF programs are concurrently updating.
> "
> and more in commit log:
> "
> - load eBPF program
>   fd = bpf(BPF_PROG_LOAD, union bpf_attr *attr, u32 size)
>
>   where 'attr' is
>   struct {
>       enum bpf_prog_type prog_type;
>       __u32 insn_cnt;
>       struct bpf_insn __user *insns;
>       const char __user *license;
>   };
>   insns - array of eBPF instructions
>   license - must be GPL compatible to call helper functions marked gpl_only
>
> - unload eBPF program
>   close(fd)
> "
>
> Isn't it short and describes what it does?
> Do you want me to describe what eBPF program can do?

The problem is that everyone needs to dig around a very long patch
series to find it.  Since you're asking for a review of a syscall, it
would be nice to have everything needed to review whether the syscall
is a good idea in its present form in one place and to keep the amount
of email under control.

--Andy

-- 
Andy Lutomirski
AMA Capital Management, LLC
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists