netdev - Re: [PATCH (net.git) 3/4] stmmac: never check EEE in case of a switch is attached

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140827.162808.1981938022641305719.davem@davemloft.net>
Date:	Wed, 27 Aug 2014 16:28:08 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	peppe.cavallaro@...com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH (net.git) 3/4] stmmac: never check EEE in case of a
 switch is attached

From: Giuseppe Cavallaro <peppe.cavallaro@...com>
Date: Tue, 26 Aug 2014 09:16:22 +0200

> From: Giuseppe CAVALLARO <peppe.cavallaro@...com>
> 
> This patch is to skip the EEE initialisation when the stmmac
> is using a switch (with a fixed phy support).
> 
> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@...com>
> ---
>  drivers/net/ethernet/stmicro/stmmac/stmmac_main.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index 51a89d4..48a112f 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -276,6 +276,7 @@ static void stmmac_eee_ctrl_timer(unsigned long arg)
>  bool stmmac_eee_init(struct stmmac_priv *priv)
>  {
>  	bool ret = false;
> +	char *phy_bus_name = priv->plat->phy_bus_name;
>  
>  	/* Using PCS we cannot dial with the phy registers at this stage
>  	 * so we do not support extra feature like EEE.

Please order local variable declarations in reverse-christmas-tree order,
this means longer lines come before shorter ones.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html