netdev - Re: [PATCH] net: stmmac: fix warning from Sparse for socfpga

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140827.163343.715764078341662382.davem@davemloft.net>
Date:	Wed, 27 Aug 2014 16:33:43 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	lftan@...era.com
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	lftan.linux@...il.com, peppe.cavallaro@...com, vbridger@...era.com
Subject: Re: [PATCH] net: stmmac: fix warning from Sparse for socfpga

From: Ley Foon Tan <lftan@...era.com>
Date: Tue, 26 Aug 2014 15:11:16 +0800

> @@ -119,7 +119,8 @@ static int socfpga_dwmac_parse_data(struct socfpga_dwmac *dwmac, struct device *
>  			return -EINVAL;
>  		}
>  
> -		dwmac->splitter_base = (void *)devm_ioremap_resource(dev,
> +		dwmac->splitter_base =
> +			(void __iomem *)devm_ioremap_resource(dev,
>  			&res_splitter);

Please either put this entire call on one line (it'll only be slightly
over 80 columns, which is fine), or indent it properly.

And by properly I meant that the second and subsequent lines of a function
call must be indented precisely to the first column after the openning
parenthesis of the function call on the first line.  You must use the
appropriate number of TAB and SPACE characters necessary to do so.

If it is indented using only TAB characters, it is very likely that you
are doing it wrong.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html